Thanks Jakob! Okay rebasing/submitting asap.
--Michael
https://codereview.chromium.org/338963003/diff/110001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/338963003/diff/110001/src/arm/full-codegen-arm.cc#newcode2631
src/arm/full-codegen-arm.cc:2631: // Move the key into the right
register for the keyed load IC.
On 2014/06/30 14:12:45, Jakob wrote:
nit: unnecessary comment (doesn't say anything that couldn't be seen
in the
code)
True, deletin'.
https://codereview.chromium.org/338963003/diff/110001/src/arm/full-codegen-arm.cc#newcode4228
src/arm/full-codegen-arm.cc:4228: // Put the object both on the stack
and in the accumulator.
On 2014/06/30 14:12:45, Jakob wrote:
nit: s/accumulator/register/
Done.
https://codereview.chromium.org/338963003/diff/110001/src/arm/ic-arm.cc
File src/arm/ic-arm.cc (right):
https://codereview.chromium.org/338963003/diff/110001/src/arm/ic-arm.cc#newcode317
src/arm/ic-arm.cc:317: // -- r1 : receiver
On 2014/06/30 14:12:45, Jakob wrote:
Why doesn't this get the same treatment as e.g.
KeyedLoadIC::GenerateSloppyArguments below?
Yep, I can do that.
https://codereview.chromium.org/338963003/diff/110001/src/arm/ic-arm.cc#newcode475
src/arm/ic-arm.cc:475: // The return address is on the stack.
On 2014/06/30 14:12:45, Jakob wrote:
actually, it's in |lr|
Done.
https://codereview.chromium.org/338963003/diff/110001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://codereview.chromium.org/338963003/diff/110001/src/arm/stub-cache-arm.cc#newcode1478
src/arm/stub-cache-arm.cc:1478: // -- lr : return address
On 2014/06/30 14:12:45, Jakob wrote:
another comment that we an trim to just this line.
Done.
https://codereview.chromium.org/338963003/diff/110001/src/arm/stub-cache-arm.cc#newcode1501
src/arm/stub-cache-arm.cc:1501: // -- r0 : key
On 2014/06/30 14:12:45, Jakob wrote:
outdated. Just drop the entire comment.
Done.
https://codereview.chromium.org/338963003/diff/110001/src/arm/stub-cache-arm.cc#newcode1511
src/arm/stub-cache-arm.cc:1511: // -- r0 : key
On 2014/06/30 14:12:45, Jakob wrote:
again
Done.
https://codereview.chromium.org/338963003/diff/110001/src/arm64/ic-arm64.cc
File src/arm64/ic-arm64.cc (right):
https://codereview.chromium.org/338963003/diff/110001/src/arm64/ic-arm64.cc#newcode412
src/arm64/ic-arm64.cc:412: // -- lr : return address
On 2014/06/30 14:12:45, Jakob wrote:
another comment that can be trimmed to "The return address is in lr.",
at least
if you use named registers below, possibly instead of the ASSERTs.
Done.
https://codereview.chromium.org/338963003/diff/110001/src/arm64/ic-arm64.cc#newcode496
src/arm64/ic-arm64.cc:496: __ Ldr(x0, unmapped_location);
On 2014/06/30 14:12:45, Jakob wrote:
I'd s/x0/result/ here (and in the next line)
Done.
https://codereview.chromium.org/338963003/diff/110001/src/arm64/ic-arm64.cc#newcode762
src/arm64/ic-arm64.cc:762: // Slow case
On 2014/06/30 14:12:45, Jakob wrote:
nit: trailing full stop please.
Done.
https://codereview.chromium.org/338963003/diff/110001/src/arm64/ic-arm64.cc#newcode780
src/arm64/ic-arm64.cc:780: void
KeyedLoadIC::GenerateString(MacroAssembler* masm) {
On 2014/06/30 14:12:45, Jakob wrote:
Wohoo! Register refactoring nirvana -- nothing to do here :-)
:D
https://codereview.chromium.org/338963003/diff/110001/src/arm64/stub-cache-arm64.cc
File src/arm64/stub-cache-arm64.cc (right):
https://codereview.chromium.org/338963003/diff/110001/src/arm64/stub-cache-arm64.cc#newcode1453
src/arm64/stub-cache-arm64.cc:1453: // -- lr : return address
On 2014/06/30 14:12:45, Jakob wrote:
one more comment to trim.
Done.
https://codereview.chromium.org/338963003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
