[v8-dev] Move libplatform files into v8::platform namespace (issue 336313017 by [email protected])

Mon, 30 Jun 2014 08:35:53 -0700 

Reviewers: Jakob,

Description:
Move libplatform files into v8::platform namespace

BUG=none
[email protected]
LOG=n

Please review this at https://codereview.chromium.org/336313017/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+20, -15 lines):
  M src/libplatform/default-platform.h
  M src/libplatform/default-platform.cc
  M src/libplatform/task-queue.h
  M src/libplatform/task-queue.cc
  M src/libplatform/worker-thread.h
  M src/libplatform/worker-thread.cc
  M src/v8.cc
  M test/cctest/test-libplatform.h
  M test/cctest/test-libplatform-task-queue.cc
  M test/cctest/test-libplatform-worker-thread.cc


Index: src/libplatform/default-platform.cc
diff --git a/src/libplatform/default-platform.cc b/src/libplatform/default-platform.cc index 3cba2f6ca09d5b895cf470b870f7e4fadd05e3c1..2d346825722d8acd654c79d80a83c0ac5ccb820e 100644 
--- a/src/libplatform/default-platform.cc
+++ b/src/libplatform/default-platform.cc
@@ -12,7 +12,7 @@
 #include "src/libplatform/worker-thread.h"

 namespace v8 {
-namespace internal {
+namespace platform {


 const int DefaultPlatform::kMaxThreadPoolSize = 4;
@@ -66,4 +66,4 @@ void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) { 
   delete task;
 }

-} }  // namespace v8::internal
+} }  // namespace v8::platform
Index: src/libplatform/default-platform.h
diff --git a/src/libplatform/default-platform.h b/src/libplatform/default-platform.h index 14e002b882b79446d9ddad295534d0a124209ff1..c5f6fae3abaf79a97d405f5837774af1fd408b7f 100644 
--- a/src/libplatform/default-platform.h
+++ b/src/libplatform/default-platform.h
@@ -13,7 +13,7 @@
 #include "src/libplatform/task-queue.h"

 namespace v8 {
-namespace internal {
+namespace platform {

 class TaskQueue;
 class Thread;
@@ -47,7 +47,7 @@ class DefaultPlatform : public Platform {
 };


-} }  // namespace v8::internal
+} }  // namespace v8::platform


 #endif  // V8_LIBPLATFORM_DEFAULT_PLATFORM_H_
Index: src/libplatform/task-queue.cc
diff --git a/src/libplatform/task-queue.cc b/src/libplatform/task-queue.cc
index a5d08f1a14dbc9b1bb62f45d631219cccf0ab5cd..0158830cced55c1cb6d9fc8ef18e437a348fcfa0 100644 
--- a/src/libplatform/task-queue.cc
+++ b/src/libplatform/task-queue.cc
@@ -7,7 +7,7 @@
 #include "src/base/logging.h"

 namespace v8 {
-namespace internal {
+namespace platform {

 TaskQueue::TaskQueue() : process_queue_semaphore_(0), terminated_(false) {}

@@ -53,4 +53,4 @@ void TaskQueue::Terminate() {
   process_queue_semaphore_.Signal();
 }

-} }  // namespace v8::internal
+} }  // namespace v8::platform
Index: src/libplatform/task-queue.h
diff --git a/src/libplatform/task-queue.h b/src/libplatform/task-queue.h
index f438cb54643293a1c72b5d5dd2bec210bc98475c..eb9d6987e9560520896d223afe57d74f4699c2d5 100644 
--- a/src/libplatform/task-queue.h
+++ b/src/libplatform/task-queue.h
@@ -15,7 +15,7 @@ namespace v8 {

 class Task;

-namespace internal {
+namespace platform {

 class TaskQueue {
  public:
@@ -41,7 +41,7 @@ class TaskQueue {
   DISALLOW_COPY_AND_ASSIGN(TaskQueue);
 };

-} }  // namespace v8::internal
+} }  // namespace v8::platform


 #endif  // V8_LIBPLATFORM_TASK_QUEUE_H_
Index: src/libplatform/worker-thread.cc
diff --git a/src/libplatform/worker-thread.cc b/src/libplatform/worker-thread.cc index 6b3892cbd2fd62cb82e130bb3debe93fe21285e3..239403b097769d8e75777951f320d84be1937b58 100644 
--- a/src/libplatform/worker-thread.cc
+++ b/src/libplatform/worker-thread.cc
@@ -8,7 +8,7 @@
 #include "src/libplatform/task-queue.h"

 namespace v8 {
-namespace internal {
+namespace platform {

 WorkerThread::WorkerThread(TaskQueue* queue)
     : Thread("V8 WorkerThread"), queue_(queue) {
@@ -28,4 +28,4 @@ void WorkerThread::Run() {
   }
 }

-} }  // namespace v8::internal
+} }  // namespace v8::platform
Index: src/libplatform/worker-thread.h
diff --git a/src/libplatform/worker-thread.h b/src/libplatform/worker-thread.h index 5942b93660a2633b7b057af414075ad22b866611..5550f16a7f69a2817dbeb21661ea156f5e456eb2 100644 
--- a/src/libplatform/worker-thread.h
+++ b/src/libplatform/worker-thread.h
@@ -12,7 +12,7 @@

 namespace v8 {

-namespace internal {
+namespace platform {

 class TaskQueue;

@@ -32,7 +32,7 @@ class WorkerThread : public base::Thread {
   DISALLOW_COPY_AND_ASSIGN(WorkerThread);
 };

-} }  // namespace v8::internal
+} }  // namespace v8::platform


 #endif  // V8_LIBPLATFORM_WORKER_THREAD_H_
Index: src/v8.cc
diff --git a/src/v8.cc b/src/v8.cc
index 394629cdda9804005099853ed18aa3ce21f69fa4..9a85e06a2ec7ac8b182bcf680fdc08d4926644d5 100644 
--- a/src/v8.cc
+++ b/src/v8.cc
@@ -42,7 +42,8 @@ bool V8::Initialize(Deserializer* des) {
   if (isolate->IsInitialized()) return true;

 #ifdef V8_USE_DEFAULT_PLATFORM
-  DefaultPlatform* platform = static_cast<DefaultPlatform*>(platform_);
+  platform::DefaultPlatform* platform =
+      static_cast<platform::DefaultPlatform*>(platform_);
   platform->SetThreadPoolSize(isolate->max_available_threads());
// We currently only start the threads early, if we know that we'll use them. 
   if (FLAG_job_based_sweeping) platform->EnsureInitialized();
@@ -63,7 +64,8 @@ void V8::TearDown() {
   Sampler::TearDown();

 #ifdef V8_USE_DEFAULT_PLATFORM
-  DefaultPlatform* platform = static_cast<DefaultPlatform*>(platform_);
+  platform::DefaultPlatform* platform =
+      static_cast<platform::DefaultPlatform*>(platform_);
   platform_ = NULL;
   delete platform;
 #endif
@@ -93,7 +95,7 @@ void V8::InitializeOncePerProcessImpl() {
base::OS::Initialize(FLAG_random_seed, FLAG_hard_abort, FLAG_gc_fake_mmap); 

 #ifdef V8_USE_DEFAULT_PLATFORM
-  platform_ = new DefaultPlatform;
+  platform_ = new platform::DefaultPlatform;
 #endif
   Sampler::SetUp();
   CpuFeatures::Probe(false);
Index: test/cctest/test-libplatform-task-queue.cc
diff --git a/test/cctest/test-libplatform-task-queue.cc b/test/cctest/test-libplatform-task-queue.cc index 5d997d94d26b0582950c9c0b60c7f5062c2ddd14..630686b45956260ebbbd3ae823cc8ac400aaecdf 100644 
--- a/test/cctest/test-libplatform-task-queue.cc
+++ b/test/cctest/test-libplatform-task-queue.cc
@@ -32,6 +32,7 @@
 #include "test/cctest/test-libplatform.h"

 using namespace v8::internal;
+using namespace v8::platform;


 TEST(TaskQueueBasic) {
Index: test/cctest/test-libplatform-worker-thread.cc
diff --git a/test/cctest/test-libplatform-worker-thread.cc b/test/cctest/test-libplatform-worker-thread.cc index 994750fd3dca64abac82d4ed04354c68caf5dd36..cd6336a03265d4bd05dc8bb64cb9614b1908869a 100644 
--- a/test/cctest/test-libplatform-worker-thread.cc
+++ b/test/cctest/test-libplatform-worker-thread.cc
@@ -33,6 +33,7 @@
 #include "test/cctest/test-libplatform.h"

 using namespace v8::internal;
+using namespace v8::platform;


 TEST(WorkerThread) {
Index: test/cctest/test-libplatform.h
diff --git a/test/cctest/test-libplatform.h b/test/cctest/test-libplatform.h
index 6e8d2b17c9b3e241101ad156221559f19c5590fb..7d0e352b9f174c6a768c2ab2eb0f71e3cdd58be2 100644 
--- a/test/cctest/test-libplatform.h
+++ b/test/cctest/test-libplatform.h
@@ -33,6 +33,7 @@
 #include "test/cctest/cctest.h"

 using namespace v8::internal;
+using namespace v8::platform;

 class TaskCounter {
  public:


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to