Reviewers: loislo, yurys_ooo,
Description:
Make JsNative1JsNative2JsSample cctest work on Win Release
MSVC optimization realizes that CallJsFunction2 is just the same as
CallJsFunction, so it eliminates the former making the call stack contain
two
instances of the same function.
The patch makes two functions distinct.
LOG=N
Please review this at https://codereview.chromium.org/357383003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -3 lines):
M test/cctest/cctest.status
M test/cctest/test-cpu-profiler.cc
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index
f4fadb3209d5e9298521e222db839642438576bb..78f94a07d3babbf7383e5e4efc364dd83da23e13
100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -152,9 +152,6 @@
# BUG(2999).
'test-cpu-profiler/CollectCpuProfile': [PASS, FAIL],
- # BUG(3055).
- 'test-cpu-profiler/JsNative1JsNative2JsSample': [PASS, ['mode ==
release', FAIL], ['mode == debug', FLAKY]],
-
# BUG(3005).
'test-alloc/CodeRange': [PASS, FAIL],
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc
b/test/cctest/test-cpu-profiler.cc
index
6e5e23b4845f57561e42f3b45e24d4990b5751e3..be75ea9b9cf84436e41878da28699268e8a8ab66
100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -1491,6 +1491,7 @@ TEST(JsNativeJsRuntimeJsSample) {
static void CallJsFunction2(const v8::FunctionCallbackInfo<v8::Value>&
info) {
+ i::OS::Print("In CallJsFunction2\n");
CallJsFunction(info);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
