lgtm with nits:
https://codereview.chromium.org/352173006/diff/40001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/352173006/diff/40001/src/accessors.cc#newcode159
src/accessors.cc:159:
isolate->native_context()->number_function()->initial_map()) {
While you are here: isolate->number_function()->initial_map()
https://codereview.chromium.org/352173006/diff/40001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/352173006/diff/40001/src/api.cc#newcode5831
src/api.cc:5831: handle(
While you are here: the whole thing handle(isolate->...->XXX()) could be
replaced with isolate->XXX() now.
https://codereview.chromium.org/352173006/diff/40001/src/api.cc#newcode5849
src/api.cc:5849: handle(isolate->native_context()->promise_create()),
Same here.
https://codereview.chromium.org/352173006/diff/40001/src/api.cc#newcode5873
src/api.cc:5873: handle(isolate->native_context()->promise_resolve()),
Same here.
https://codereview.chromium.org/352173006/diff/40001/src/api.cc#newcode5890
src/api.cc:5890: handle(isolate->native_context()->promise_reject()),
Same here.
https://codereview.chromium.org/352173006/diff/40001/src/api.cc#newcode5908
src/api.cc:5908: handle(isolate->native_context()->promise_chain()),
Same here.
https://codereview.chromium.org/352173006/diff/40001/src/api.cc#newcode5927
src/api.cc:5927: handle(isolate->native_context()->promise_catch()),
Same here.
https://codereview.chromium.org/352173006/diff/40001/src/api.cc#newcode5946
src/api.cc:5946: handle(isolate->native_context()->promise_then()),
Same here.
https://codereview.chromium.org/352173006/diff/40001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/352173006/diff/40001/src/bootstrapper.cc#newcode188
src/bootstrapper.cc:188: Handle<GlobalObject>* global_proxy_out);
global_object_out
https://codereview.chromium.org/352173006/diff/40001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/352173006/diff/40001/src/hydrogen.cc#newcode8435
src/hydrogen.cc:8435:
receiver_maps->Add(handle(function->context()->global_proxy()->map()),
function->global_proxy()
https://codereview.chromium.org/352173006/diff/40001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/352173006/diff/40001/src/objects.h#newcode7602
src/objects.h:7602: inline JSObject* global_proxy();
Consider moving declaration and definition of this method after
set_context() to keep the latter closer to context().
https://codereview.chromium.org/352173006/diff/40001/src/objects.h#newcode7857
src/objects.h:7857: // [global receiver]: the global receiver object of
the context
Outdated comment.
https://codereview.chromium.org/352173006/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/352173006/diff/40001/src/runtime.cc#newcode13037
src/runtime.cc:13037:
isolate->native_context()->sloppy_arguments_boilerplate());
Same here.
https://codereview.chromium.org/352173006/diff/40001/src/runtime.cc#newcode13066
src/runtime.cc:13066: Handle<JSFunction>
constructor(isolate->native_context()->array_function());
Same here.
https://codereview.chromium.org/352173006/diff/40001/src/runtime.cc#newcode13149
src/runtime.cc:13149: isolate->native_context()->array_function());
Same here.
https://codereview.chromium.org/352173006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
