Revision: 22113
Author: [email protected]
Date: Tue Jul 1 10:10:12 2014 UTC
Log: Make JsNative1JsNative2JsSample cctest work on Win Release
MSVC optimization realizes that CallJsFunction2 is just the same as
CallJsFunction, so it eliminates the former making the call stack contain
two instances of the same function.
The patch makes two functions distinct.
LOG=N
BUG=v8:3055
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/357383003
http://code.google.com/p/v8/source/detail?r=22113
Modified:
/branches/bleeding_edge/test/cctest/cctest.status
/branches/bleeding_edge/test/cctest/test-cpu-profiler.cc
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.status Tue Jun 10 13:23:05
2014 UTC
+++ /branches/bleeding_edge/test/cctest/cctest.status Tue Jul 1 10:10:12
2014 UTC
@@ -152,9 +152,6 @@
# BUG(2999).
'test-cpu-profiler/CollectCpuProfile': [PASS, FAIL],
- # BUG(3055).
- 'test-cpu-profiler/JsNative1JsNative2JsSample': [PASS, ['mode ==
release', FAIL], ['mode == debug', FLAKY]],
-
# BUG(3005).
'test-alloc/CodeRange': [PASS, FAIL],
=======================================
--- /branches/bleeding_edge/test/cctest/test-cpu-profiler.cc Mon Jun 30
13:25:46 2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-cpu-profiler.cc Tue Jul 1
10:10:12 2014 UTC
@@ -1490,6 +1490,7 @@
static void CallJsFunction2(const v8::FunctionCallbackInfo<v8::Value>&
info) {
+ v8::base::OS::Print("In CallJsFunction2\n");
CallJsFunction(info);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
