We need the following flags as well:
cflags: -gline-tables-only (in Release), -fPIC, -DMEMORY_SANITIZER
ldflags: -pie (in executables)
https://codereview.chromium.org/367623002/diff/20001/Makefile
File Makefile (right):
https://codereview.chromium.org/367623002/diff/20001/Makefile#newcode150
Makefile:150: GYPFLAGS += -Dmsan=1 -Dmsan_track_origins=2
You set msan_track_origins here but you don't use that variable in the
GYP file. The GYP file should pass something like
-fsanitize-memory-track-origins=<(msan_track_origins).
Also, as said in the other comment, please reconsider hardcoding this to
2.
https://codereview.chromium.org/367623002/diff/20001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/367623002/diff/20001/build/standalone.gypi#newcode193
build/standalone.gypi:193: '-fsanitize-memory-track-origins=2',
-fsanitize-memory-track-origins can take values from 0 (fastest, least
amount of information) to 2 (slowest, most helpful reports,
experimental). Please expose this setting rather than hardcode it to 2.
https://codereview.chromium.org/367623002/diff/20001/build/standalone.gypi#newcode195
build/standalone.gypi:195: '-w', # http://crbug.com/162783
The linked issue refers to ASan, not MSan. We don't use -w with MSan in
Chrome and shouldn't need it for V8, either.
https://codereview.chromium.org/367623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
