LGTM
http://codereview.chromium.org/162007/diff/2014/3012 File src/arm/cfg-arm.cc (right): http://codereview.chromium.org/162007/diff/2014/3012#newcode105 Line 105: __ RecordStatementPosition(pos_); Should we use "masm->" instead of "__" here? Using "__" might add extra coverage code. http://codereview.chromium.org/162007/diff/2014/3010 File src/x64/cfg-x64.cc (right): http://codereview.chromium.org/162007/diff/2014/3010#newcode129 Line 129: __ RecordPosition(pos_); These functions are all identical, and uses only generic MacroAssembler functionality. There shouldn't need to be three of them. http://codereview.chromium.org/162007 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
