Reviewers: jochen,
Description:
Re-enable the check in GetRangeConstraint() function.
Now that we have ASSERT() macro in src/base/logging.h we can use it in
safe_conversions_impl.h, re-enable this assertion and fix the TODO
there.
BUG=None
TEST=None
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/369483003/
SVN Base: git://github.com/v8/v8.git@master
Affected files (+3, -3 lines):
M src/base/safe_conversions_impl.h
Index: src/base/safe_conversions_impl.h
diff --git a/src/base/safe_conversions_impl.h
b/src/base/safe_conversions_impl.h
index
2226f17aebd1a2a2367d99e1178cb7bcd4efd668..0a9ed9b71978eb55690bb403029988a603958db3
100644
--- a/src/base/safe_conversions_impl.h
+++ b/src/base/safe_conversions_impl.h
@@ -10,6 +10,7 @@
#include <limits>
+#include "src/base/logging.h"
#include "src/base/macros.h"
namespace v8 {
@@ -98,9 +99,8 @@ enum RangeConstraint {
// Helper function for coercing an int back to a RangeContraint.
inline RangeConstraint GetRangeConstraint(int integer_range_constraint) {
- // TODO(jochen/jkummerow): Re-enable this when checks.h is available in
base.
- // ASSERT(integer_range_constraint >= RANGE_VALID &&
- // integer_range_constraint <= RANGE_INVALID);
+ ASSERT(integer_range_constraint >= RANGE_VALID &&
+ integer_range_constraint <= RANGE_INVALID);
return static_cast<RangeConstraint>(integer_range_constraint);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
