Revision: 22138
Author: [email protected]
Date: Wed Jul 2 07:02:39 2014 UTC
Log: Re-enable the check in GetRangeConstraint() function.
Now that we have ASSERT() macro in src/base/logging.h we can use it in
safe_conversions_impl.h, re-enable this assertion and fix the TODO
there.
BUG=None
TEST=None
[email protected]
LOG=n
Review URL: https://codereview.chromium.org/369483003
Patch from Thiago Farina <[email protected]>.
http://code.google.com/p/v8/source/detail?r=22138
Modified:
/branches/bleeding_edge/src/base/safe_conversions_impl.h
=======================================
--- /branches/bleeding_edge/src/base/safe_conversions_impl.h Wed Jun 18
11:01:54 2014 UTC
+++ /branches/bleeding_edge/src/base/safe_conversions_impl.h Wed Jul 2
07:02:39 2014 UTC
@@ -10,6 +10,7 @@
#include <limits>
+#include "src/base/logging.h"
#include "src/base/macros.h"
namespace v8 {
@@ -98,9 +99,8 @@
// Helper function for coercing an int back to a RangeContraint.
inline RangeConstraint GetRangeConstraint(int integer_range_constraint) {
- // TODO(jochen/jkummerow): Re-enable this when checks.h is available in
base.
- // ASSERT(integer_range_constraint >= RANGE_VALID &&
- // integer_range_constraint <= RANGE_INVALID);
+ ASSERT(integer_range_constraint >= RANGE_VALID &&
+ integer_range_constraint <= RANGE_INVALID);
return static_cast<RangeConstraint>(integer_range_constraint);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
