LGTM with comments.
Of course the high-level comment is that handling/hiding flaky failures in
the
infrastructure takes away incentive to fix flaky tests for good, which in
the
long run might have undesirable consequences...
https://codereview.chromium.org/360113003/diff/20001/tools/run-deopt-fuzzer.py
File tools/run-deopt-fuzzer.py (right):
https://codereview.chromium.org/360113003/diff/20001/tools/run-deopt-fuzzer.py#newcode375
tools/run-deopt-fuzzer.py:375: 0,
nit: may want to add a comment what the False/True/0/0 lines are
specifying
https://codereview.chromium.org/360113003/diff/20001/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/360113003/diff/20001/tools/run-tests.py#newcode189
tools/run-tests.py:189: help="Maximum number of failures to rerun.",
nit: for better clarity, s/failures/failing test cases/. And maybe
accordingly change the other option's description to "Number of times to
rerun each failing test case".
https://codereview.chromium.org/360113003/diff/20001/tools/testrunner/local/execution.py
File tools/testrunner/local/execution.py (right):
https://codereview.chromium.org/360113003/diff/20001/tools/testrunner/local/execution.py#newcode123
tools/testrunner/local/execution.py:123: test.duration = None
I don't think we need to reset duration and output (but it shouldn't
hurt if we do).
https://codereview.chromium.org/360113003/diff/20001/tools/testrunner/objects/testcase.py
File tools/testrunner/objects/testcase.py (right):
https://codereview.chromium.org/360113003/diff/20001/tools/testrunner/objects/testcase.py#newcode55
tools/testrunner/objects/testcase.py:55: self.dependency,
list(self.outcomes or []), self.id, self.run]
IIUC, |run| is always 1 when a test is packed for network transmission.
So we could skip the value here...
https://codereview.chromium.org/360113003/diff/20001/tools/testrunner/objects/testcase.py#newcode64
tools/testrunner/objects/testcase.py:64: test.run = task[6]
...and simply fill in 1 here (or not set it at all, as the constructor
defaults to 1 anyway). Sending bytes over the wire is fairly expensive,
compared to almost anything else the test runner does.
https://codereview.chromium.org/360113003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
