LGTM
http://codereview.chromium.org/164056/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/164056/diff/1/2#newcode178 Line 178: static void LoadFloatOperand(MacroAssembler* masm, Register scratch); Add an empty line after declarations. http://codereview.chromium.org/164056/diff/1/2#newcode214 Line 214: // Test if operands are smi or number objects (fp). Requirements: Unclear whether it tests (is smi or is heapnumber) or just whether it is a heapnumber. http://codereview.chromium.org/164056/diff/1/2#newcode3618 Line 3618: __ sahf(); Using sahf is theoretically unsafe (not supported on some early x64 chips). http://codereview.chromium.org/164056 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
