Revision: 22205
Author: [email protected]
Date: Thu Jul 3 16:22:34 2014 UTC
Log: MIPS: Remove unnecessary check in RegExpExecStub.
Port r22202 (cd07587)
BUG=v8:592
LOG=N
[email protected]
Review URL: https://codereview.chromium.org/371503002
http://code.google.com/p/v8/source/detail?r=22205
Modified:
/branches/bleeding_edge/src/mips/code-stubs-mips.cc
=======================================
--- /branches/bleeding_edge/src/mips/code-stubs-mips.cc Thu Jul 3 12:27:23
2014 UTC
+++ /branches/bleeding_edge/src/mips/code-stubs-mips.cc Thu Jul 3 16:22:34
2014 UTC
@@ -2670,16 +2670,12 @@
__ Branch(&failure, eq, v0,
Operand(NativeRegExpMacroAssembler::FAILURE));
// If not exception it can only be retry. Handle that in the runtime
system.
__ Branch(&runtime, ne, v0,
Operand(NativeRegExpMacroAssembler::EXCEPTION));
- // Result must now be exception. If there is no pending exception
already a
- // stack overflow (on the backtrack stack) was detected in RegExp code
but
- // haven't created the exception yet. Handle that in the runtime system.
- // TODO(592): Rerunning the RegExp to get the stack overflow exception.
+
+ // Result must now be exception.
__ li(a1, Operand(isolate()->factory()->the_hole_value()));
__ li(a2, Operand(ExternalReference(Isolate::kPendingExceptionAddress,
isolate())));
__ lw(v0, MemOperand(a2, 0));
- __ Branch(&runtime, eq, v0, Operand(a1));
-
__ sw(a1, MemOperand(a2, 0)); // Clear pending exception.
// Check if the exception is a termination. If so, throw as uncatchable.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
