https://codereview.chromium.org/345903004/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/345903004/diff/1/BUILD.gn#newcode1067
BUILD.gn:1067: source_set("v8_libplatform") {
Does this needs visibility?
visibility = ":*" # Only targets in this file can depend on this.
v8_libbase has this.
If it does not need, then my understanding is that external targets can
depend on this. Is that right?
https://codereview.chromium.org/345903004/diff/1/BUILD.gn#newcode1080
BUILD.gn:1080: configs += [ ":internal_config", ":features",
":toolchain" ]
does it need also these configs?
https://codereview.chromium.org/345903004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
