Reviewers: Weiliang, Sven Panne,
Message:
weiliang.
please review this patch.
thanks.
Description:
X87: Start using OStreams.
port r22179
original commit message:
Note that until everything is OStream-based, there are a few places
where we have to do some impedance matching. A few accessors had to be
const-corrected on the way.
BUG=
Please review this at https://codereview.chromium.org/370673002/
SVN Base: https://github.com/v8/v8.git@master
Affected files (+10, -10 lines):
M src/x87/code-stubs-x87.h
Index: src/x87/code-stubs-x87.h
diff --git a/src/x87/code-stubs-x87.h b/src/x87/code-stubs-x87.h
index
6dbb44fc5361888809281ff51fa83a0d8b084bd5..e6df2c3445c71f3d29cf4c1f9c98795b4f879ace
100644
--- a/src/x87/code-stubs-x87.h
+++ b/src/x87/code-stubs-x87.h
@@ -28,8 +28,8 @@ class StoreBufferOverflowStub: public PlatformCodeStub {
virtual bool SometimesSetsUpAFrame() { return false; }
private:
- Major MajorKey() { return StoreBufferOverflow; }
- int MinorKey() { return 0; }
+ Major MajorKey() const { return StoreBufferOverflow; }
+ int MinorKey() const { return 0; }
};
@@ -68,8 +68,8 @@ class SubStringStub: public PlatformCodeStub {
explicit SubStringStub(Isolate* isolate) : PlatformCodeStub(isolate) {}
private:
- Major MajorKey() { return SubString; }
- int MinorKey() { return 0; }
+ Major MajorKey() const { return SubString; }
+ int MinorKey() const { return 0; }
void Generate(MacroAssembler* masm);
};
@@ -96,8 +96,8 @@ class StringCompareStub: public PlatformCodeStub {
Register scratch2);
private:
- virtual Major MajorKey() { return StringCompare; }
- virtual int MinorKey() { return 0; }
+ virtual Major MajorKey() const { return StringCompare; }
+ virtual int MinorKey() const { return 0; }
virtual void Generate(MacroAssembler* masm);
static void GenerateAsciiCharsCompareLoop(
@@ -154,9 +154,9 @@ class NameDictionaryLookupStub: public PlatformCodeStub
{
NameDictionary::kHeaderSize +
NameDictionary::kElementsStartIndex * kPointerSize;
- Major MajorKey() { return NameDictionaryLookup; }
+ Major MajorKey() const { return NameDictionaryLookup; }
- int MinorKey() {
+ int MinorKey() const {
return DictionaryBits::encode(dictionary_.code()) |
ResultBits::encode(result_.code()) |
IndexBits::encode(index_.code()) |
@@ -382,9 +382,9 @@ class RecordWriteStub: public PlatformCodeStub {
Mode mode);
void InformIncrementalMarker(MacroAssembler* masm);
- Major MajorKey() { return RecordWrite; }
+ Major MajorKey() const { return RecordWrite; }
- int MinorKey() {
+ int MinorKey() const {
return ObjectBits::encode(object_.code()) |
ValueBits::encode(value_.code()) |
AddressBits::encode(address_.code()) |
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
