LGTM with nits. Furthermore, a short explanation *why* this is beneficial
should
be in the CL description, making our a API change description docs easier to
write.
https://codereview.chromium.org/365153002/diff/20001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/365153002/diff/20001/include/v8.h#newcode4763
include/v8.h:4763: * Deprecated, will be removed.
I think that
Deprecated, use Isolate::SetCounterFunction instead.
would be more helpful.
https://codereview.chromium.org/365153002/diff/20001/include/v8.h#newcode4773
include/v8.h:4773: * Deprecated, will be removed.
Same here.
https://codereview.chromium.org/365153002/diff/20001/include/v8.h#newcode4776
include/v8.h:4776: static void
SetAddHistogramSampleFunction(AddHistogramSampleCallback);
Missing deprecation comment.
https://codereview.chromium.org/365153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
