lgtm with comment
https://codereview.chromium.org/367343002/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/367343002/diff/1/src/code-stubs-hydrogen.cc#newcode1662
src/code-stubs-hydrogen.cc:1662: IfBuilder* lookup_if = new
IfBuilder(this);
On 2014/07/07 11:52:10, Jakob wrote:
On 2014/07/07 07:59:06, danno wrote:
> Shouldn't you just Zone allocate this?
>
> void* buffer = zone->New(sizeof(IfBuilder));
> IfBuidler* lookup_if = new (buffer) IfBuilder(this)?
I'm not sure. In what way would that be better? We never zone-allocate
IfBuilders. And I don't quite see why we should; they're very
short-lived
(whereas the graph builder's zone lives "forever"); and we don't need
that many
of them (just kEntriesPerBucket == 4).
But if you prefer zone allocation, I can certainly zone-allocate them.
Well, since we generally avoid allocating from the C++ heap, I
personally think the Zone allocation would be better, but it's your
call.
https://codereview.chromium.org/367343002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
