Reviewers: Weiliang, Toon Verwaest,

Message:
weiliang.
please review this patch.
thanks.

Description:
X87: Fix computed properties on object literals with a double as propertyname.

port r22255.

original commit message:

  Fix computed properties on object literals with a double as propertyname.

BUG=

Please review this at https://codereview.chromium.org/379513002/

SVN Base: https://github.com/v8/v8.git@master

Affected files (+2, -2 lines):
  M src/x87/full-codegen-x87.cc


Index: src/x87/full-codegen-x87.cc
diff --git a/src/x87/full-codegen-x87.cc b/src/x87/full-codegen-x87.cc
index 0a0d96ec1bd96aba79c9209b0f714c2c5e332ad8..b132a757833944feb21ed79ad061bf0b03abc146 100644
--- a/src/x87/full-codegen-x87.cc
+++ b/src/x87/full-codegen-x87.cc
@@ -1643,8 +1643,8 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
         VisitForStackValue(key);
         VisitForStackValue(value);
         if (property->emit_store()) {
-          __ push(Immediate(Smi::FromInt(NONE)));  // PropertyAttributes
-          __ CallRuntime(Runtime::kAddProperty, 4);
+          __ push(Immediate(Smi::FromInt(SLOPPY)));  // Strict mode
+          __ CallRuntime(Runtime::kSetProperty, 4);
         } else {
           __ Drop(3);
         }


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to