Reviewers: William Hesse, Message: Issues to be addressed in the future:
1. It's clear that much of the graph building code can be shared. Might be enough to have superclasses for one-operand, two-operand, and three-operand instructions. 2. Same with codegen code. We could go a long way by adding things like Push and Call with a common semantics to the macro assemblers and using platform-specific constant symbolic registers (eg, kAccumulator, kScratch, ...). 3. There is a pop/push sequence in the property loads which could be eliminated, but it's probably better to make the ICs drop the receiver and key if there is one. Description: Added support for property loads to the CFG builder and fast-mode compiler. Please review this at http://codereview.chromium.org/165129 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/cfg-arm.cc M src/cfg.h M src/cfg.cc M src/ia32/cfg-ia32.cc M src/x64/cfg-x64.cc --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
