On 2014/07/08 06:37:11, Sven Panne wrote:
DBC
https://codereview.chromium.org/368833003/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/368833003/diff/1/src/ic.cc#newcode73
src/ic.cc:73: // TODO(jkummerow): Add support for "apply". The logic is
roughly:
Hmmm, can we extract the body of the while loop in
JavaScriptFrame::PrintTop
and
use it here instead of copying >30 lines of highly non-trivial code? As
it is,
this is extremely ugly and guaranteed to diverge/break at some point.
+1
lgtm, otherwise.
https://codereview.chromium.org/368833003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
