Reviewers: danno,
Message:
Hi Danno,
Here is a fix for the bug we discussed. Two callouts:
1) Note that in the bailout case we might discover we should change to a
dictionary. I return a sentinel SMI to signal that. Terrible hack?
2) In lithium-codegen.cc I weaken an assert to allow HCallWithDescriptor
instructions that a) have an environment and b) have no side effects. This
seems
necessary and correct but I wonder if there are deeper implications.
thx,
--Michael
Description:
Use a stub in crankshaft for grow store arrays.
We were deopting without learning anything.
BUG=v8:3417
Please review this at https://codereview.chromium.org/368263003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+395, -35 lines):
M src/code-stubs.h
M src/code-stubs.cc
M src/code-stubs-hydrogen.cc
M src/hydrogen.cc
M src/hydrogen-instructions.h
M src/hydrogen-instructions.cc
M src/ia32/code-stubs-ia32.cc
M src/ia32/lithium-ia32.h
M src/ia32/lithium-ia32.cc
M src/isolate.cc
M src/lithium-codegen.cc
M src/runtime.h
M src/runtime.cc
A test/mjsunit/ensure-growing-store-learns.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
