Reviewers: yangguo,
Description:
Change some names in Promise instrumentation events.
TBR=yangguo
Please review this at https://codereview.chromium.org/374103002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M src/promise.js
M test/mjsunit/es6/debug-promises-async-task-event.js
Index: src/promise.js
diff --git a/src/promise.js b/src/promise.js
index
9289cc580ae28de7a3475593dd7f497cb688f88e..c94e05968dac17b9bb7a5bbee3bacf2aa42c85da
100644
--- a/src/promise.js
+++ b/src/promise.js
@@ -139,7 +139,7 @@ var lastMicrotaskId = 0;
});
if (instrumenting) {
id = ++lastMicrotaskId;
- name = status > 0 ? "Promise.Resolved" : "Promise.Rejected";
+ name = status > 0 ? "Promise.resolve" : "Promise.reject";
%DebugAsyncTaskEvent({ type: "enqueue", id: id, name: name });
}
}
Index: test/mjsunit/es6/debug-promises-async-task-event.js
diff --git a/test/mjsunit/es6/debug-promises-async-task-event.js
b/test/mjsunit/es6/debug-promises-async-task-event.js
index
eba5f8eb9f0cf1be6dff5b217574aba3176e4bdd..88030a2e73c93d6d02fe26052c7a783df4bf49c9
100644
--- a/test/mjsunit/es6/debug-promises-async-task-event.js
+++ b/test/mjsunit/es6/debug-promises-async-task-event.js
@@ -37,7 +37,7 @@ function listener(event, exec_state, event_data, data) {
if (base_id < 0)
base_id = event_data.id();
var id = event_data.id() - base_id + 1;
- assertEquals("Promise.Resolved", event_data.name());
+ assertEquals("Promise.resolve", event_data.name());
assertLog(event_data.type() + " #" + id);
} catch (e) {
print(e + e.stack)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.