Reviewers: ulan,
Message:
PTAL Ulan, thanks.
Description:
[Arm]: Optimize ConstantPoolBuilder::Populate code by minimizing calls to
OffsetOfElementAt
Calling OffsetOfElementAt becomes expensive when compiling functions with
many
constant pool entries. This was causing a regression in MandreelLatency due
to the time spent populating the constant pool array for large compiled
functions.
This change avoids calling OffsetOfElementAt for each entry, and instead
keeps
track of the current offsets in ConstantPoolBuilder::Populate. This gives
the
following improvements on a Nexus 5:
Inline CP | OOL CP (before CL) | OOL CP (after CL)
Mandreel: 4305 | 3961 | 4120
MandreelLatency: 2298 | 1198 | 1994
Octane Score: 5197 | 4982 | 5152
Please review this at https://codereview.chromium.org/376973002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+81, -22 lines):
M src/arm/assembler-arm.cc
M src/objects.h
M src/objects-inl.h
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
