Revision: 22289
Author:   [email protected]
Date:     Wed Jul  9 07:32:55 2014 UTC
Log:      Flush ICache after deserializing code.

[email protected]

Review URL: https://codereview.chromium.org/375223002
http://code.google.com/p/v8/source/detail?r=22289

Modified:
 /branches/bleeding_edge/src/serialize.cc
 /branches/bleeding_edge/src/serialize.h
 /branches/bleeding_edge/test/cctest/cctest.status

=======================================
--- /branches/bleeding_edge/src/serialize.cc    Tue Jul  8 09:04:08 2014 UTC
+++ /branches/bleeding_edge/src/serialize.cc    Wed Jul  9 07:32:55 2014 UTC
@@ -1907,6 +1907,7 @@
   }
   Object* root;
   deserializer.DeserializePartial(isolate, &root);
+  deserializer.FlushICacheForNewCodeObjects();
   ASSERT(root->IsSharedFunctionInfo());
   return root;
 }
=======================================
--- /branches/bleeding_edge/src/serialize.h     Tue Jul  8 09:04:08 2014 UTC
+++ /branches/bleeding_edge/src/serialize.h     Wed Jul  9 07:32:55 2014 UTC
@@ -248,6 +248,8 @@
     ASSERT(space_number <= LAST_SPACE);
     reservations_[space_number] = reservation;
   }
+
+  void FlushICacheForNewCodeObjects();

  private:
   virtual void VisitPointers(Object** start, Object** end);
@@ -285,8 +287,6 @@
     offset <<= kObjectAlignmentBits;
     return HeapObject::FromAddress(high_water_[space] - offset);
   }
-
-  void FlushICacheForNewCodeObjects();

   // Cached current isolate.
   Isolate* isolate_;
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.status Wed Jul 9 06:02:18 2014 UTC +++ /branches/bleeding_edge/test/cctest/cctest.status Wed Jul 9 07:32:55 2014 UTC
@@ -175,9 +175,6 @@
##############################################################################
 ['arch == arm', {

-  # Temporarily disabled test
-  'test-compiler/SerializeToplevel': [SKIP],
-
   # BUG(355): Test crashes on ARM.
   'test-log/ProfLazyMode': [SKIP],

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to