Reviewers: Christian Plesner Hansen, Message: Hi Christian,
Can you review this to me? Thanks! Description: Fixing the const correctness of String::Value. BUG=378 TEST=None Please review this at http://codereview.chromium.org/165208 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M include/v8.h Index: include/v8.h =================================================================== --- include/v8.h (revision 2654) +++ include/v8.h (working copy) @@ -918,8 +918,8 @@ public: explicit Utf8Value(Handle<v8::Value> obj); ~Utf8Value(); - char* operator*() const { return str_; } - int length() { return length_; } + const char* operator*() const { return str_; } + int length() const { return length_; } private: char* str_; int length_; @@ -940,8 +940,8 @@ public: explicit AsciiValue(Handle<v8::Value> obj); ~AsciiValue(); - char* operator*() const { return str_; } - int length() { return length_; } + const char* operator*() const { return str_; } + int length() const { return length_; } private: char* str_; int length_; @@ -961,8 +961,8 @@ public: explicit Value(Handle<v8::Value> obj); ~Value(); - uint16_t* operator*() const { return str_; } - int length() { return length_; } + const uint16_t* operator*() const { return str_; } + int length() const { return length_; } private: uint16_t* str_; int length_; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
