On 2014/07/09 10:26:10, rossberg wrote:
On 2014/07/09 07:48:33, Yang wrote:
> looking good, but I'd like to run the Object hierarchy change by
Andreas.
Looks good, but it would probably make sense to make JSWeakCollection
inherit
from JSCollection now.
On second thought, strike that. Their tables have different types, we
should not
conflate them.
So LGTM.
(In fact, I'm not sure it's the best move to conflate the also different
table
types of maps and sets either, but currently we don't have typed accessors
anyway.)
https://codereview.chromium.org/373183002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
