lgtm with a bunch of non-blocking comments.
https://codereview.chromium.org/380653003/diff/40001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/380653003/diff/40001/src/mark-compact.cc#newcode4069
src/mark-compact.cc:4069: // Force instantiation of templatized
SweepInParallel method for
Is the templatization of SweepInParallel really necessary? Would not it
just work if you always called with SWEEP_IN_PARALLEL mode?
https://codereview.chromium.org/380653003/diff/40001/src/mark-compact.cc#newcode4110
src/mark-compact.cc:4110: return max_freed;
For consistency, should not this return the maximum? (Rather than the
last value of returned by the SweepConservatively.)
https://codereview.chromium.org/380653003/diff/40001/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/380653003/diff/40001/src/spaces.cc#newcode2584
src/spaces.cc:2584: HeapObject*
PagedSpace::WaitForSweeperThreadsAndRetryAllocation(
Nit: Now the name is a bit funny - it does not always wait for the
sweeper threads.
https://codereview.chromium.org/380653003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
