Revision: 22299
Author: [email protected]
Date: Wed Jul 9 11:37:36 2014 UTC
Log: Fix test driver output for passes in predictable mode.
Passes in predictable mode were wrongly reported as failures by the json
progress indicator. This moves control about what is reported completely to
execution.py.
BUG=391747
LOG=n
[email protected], [email protected]
Review URL: https://codereview.chromium.org/382443004
http://code.google.com/p/v8/source/detail?r=22299
Modified:
/branches/bleeding_edge/tools/testrunner/local/execution.py
/branches/bleeding_edge/tools/testrunner/local/progress.py
=======================================
--- /branches/bleeding_edge/tools/testrunner/local/execution.py Tue Jul 8
15:59:23 2014 UTC
+++ /branches/bleeding_edge/tools/testrunner/local/execution.py Wed Jul 9
11:37:36 2014 UTC
@@ -138,7 +138,10 @@
else:
self.succeeded += 1
self.remaining -= 1
- self.indicator.HasRun(test, has_unexpected_output)
+ # For the indicator, everything that happens after the first run is
treated
+ # as unexpected even if it flakily passes in order to include it in the
+ # output.
+ self.indicator.HasRun(test, has_unexpected_output or test.run > 1)
if has_unexpected_output:
# Rerun test failures after the indicator has processed the results.
self._MaybeRerun(pool, test)
=======================================
--- /branches/bleeding_edge/tools/testrunner/local/progress.py Thu Jul 3
09:33:22 2014 UTC
+++ /branches/bleeding_edge/tools/testrunner/local/progress.py Wed Jul 9
11:37:36 2014 UTC
@@ -318,9 +318,9 @@
def HasRun(self, test, has_unexpected_output):
self.progress_indicator.HasRun(test, has_unexpected_output)
- if test.run == 1 and not has_unexpected_output:
- # Omit tests that pass on the first run, but collect output of tests
- # that pass when rerun.
+ if not has_unexpected_output:
+ # Omit tests that run as expected. Passing tests of reruns after
failures
+ # will have unexpected_output to be reported here has well.
return
self.results.append({
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
