Reviewers: Jakob,
Message:
PTAL. I think when I introduced the +1, I thought the driver was retrying
too
little. But these were cases where a flake was detected and then there is no
further rerun anyways.
When no flake is found (i.e. all fail) it reruns correctly (and right now
one
too much - which will be fixed with this CL).
Description:
Fix number of times failures are rerun.
BUG=374134
Please review this at https://codereview.chromium.org/379833003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M tools/testrunner/local/execution.py
Index: tools/testrunner/local/execution.py
diff --git a/tools/testrunner/local/execution.py
b/tools/testrunner/local/execution.py
index
a339eeb85d905402607a7e50f2795f192a91ba3f..a6dce636e1182b86c4952ee284c367b026aa3d17
100644
--- a/tools/testrunner/local/execution.py
+++ b/tools/testrunner/local/execution.py
@@ -104,9 +104,9 @@ class Runner(object):
return Job(command, dep_command, test.id, timeout,
self.context.verbose)
def _MaybeRerun(self, pool, test):
- if test.run <= self.context.rerun_failures_count + 1:
+ if test.run <= self.context.rerun_failures_count:
# Possibly rerun this test if its run count is below the maximum per
- # test. +1 as the flag controls reruns not including the first run.
+ # test. <= as the flag controls reruns not including the first run.
if test.run == 1:
# Count the overall number of reran tests on the first rerun.
if self.reran_tests < self.context.rerun_failures_max:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
