Revision: 22304
Author: [email protected]
Date: Wed Jul 9 14:03:05 2014 UTC
Log: Remove deprecate counter/histogram methods
Callers should use the methods with the same name on Isolate instead.
BUG=none
[email protected]
LOG=y
Review URL: https://codereview.chromium.org/371023004
http://code.google.com/p/v8/source/detail?r=22304
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/src/api.cc
/branches/bleeding_edge/src/d8.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Mon Jul 7 14:03:20 2014 UTC
+++ /branches/bleeding_edge/include/v8.h Wed Jul 9 14:03:05 2014 UTC
@@ -4760,28 +4760,6 @@
/** Get the version string. */
static const char* GetVersion();
- /**
- * Enables the host application to provide a mechanism for recording
- * statistics counters.
- *
- * Deprecated, use Isolate::SetCounterFunction instead.
- */
- static void SetCounterFunction(CounterLookupCallback);
-
- /**
- * Enables the host application to provide a mechanism for recording
- * histograms. The CreateHistogram function returns a
- * histogram which will later be passed to the AddHistogramSample
- * function.
- *
- * Deprecated, use Isolate::SetCreateHistogramFunction instead.
- * Isolate::SetAddHistogramSampleFunction instead.
- */
- static void SetCreateHistogramFunction(CreateHistogramCallback);
-
- /** Deprecated, use Isolate::SetAddHistogramSampleFunction instead. */
- static void SetAddHistogramSampleFunction(AddHistogramSampleCallback);
-
/** Callback function for reporting failed access checks.*/
static void
SetFailedAccessCheckCallbackFunction(FailedAccessCheckCallback);
=======================================
--- /branches/bleeding_edge/src/api.cc Mon Jul 7 14:03:20 2014 UTC
+++ /branches/bleeding_edge/src/api.cc Wed Jul 9 14:03:05 2014 UTC
@@ -6351,32 +6351,6 @@
}
-void V8::SetCounterFunction(CounterLookupCallback callback) {
- i::Isolate* isolate = i::Isolate::UncheckedCurrent();
- // TODO(svenpanne) The Isolate should really be a parameter.
- if (isolate == NULL) return;
- isolate->stats_table()->SetCounterFunction(callback);
-}
-
-
-void V8::SetCreateHistogramFunction(CreateHistogramCallback callback) {
- i::Isolate* isolate = i::Isolate::UncheckedCurrent();
- // TODO(svenpanne) The Isolate should really be a parameter.
- if (isolate == NULL) return;
- isolate->stats_table()->SetCreateHistogramFunction(callback);
- isolate->InitializeLoggingAndCounters();
- isolate->counters()->ResetHistograms();
-}
-
-
-void V8::SetAddHistogramSampleFunction(AddHistogramSampleCallback
callback) {
- i::Isolate* isolate = i::Isolate::UncheckedCurrent();
- // TODO(svenpanne) The Isolate should really be a parameter.
- if (isolate == NULL) return;
- isolate->stats_table()->
- SetAddHistogramSampleFunction(callback);
-}
-
void V8::SetFailedAccessCheckCallbackFunction(
FailedAccessCheckCallback callback) {
i::Isolate* isolate = i::Isolate::Current();
=======================================
--- /branches/bleeding_edge/src/d8.cc Mon Jul 7 07:19:46 2014 UTC
+++ /branches/bleeding_edge/src/d8.cc Wed Jul 9 14:03:05 2014 UTC
@@ -899,9 +899,9 @@
if (i::StrLength(i::FLAG_map_counters) != 0)
MapCounters(isolate, i::FLAG_map_counters);
if (i::FLAG_dump_counters || i::FLAG_track_gc_object_stats) {
- V8::SetCounterFunction(LookupCounter);
- V8::SetCreateHistogramFunction(CreateHistogram);
- V8::SetAddHistogramSampleFunction(AddHistogramSample);
+ isolate->SetCounterFunction(LookupCounter);
+ isolate->SetCreateHistogramFunction(CreateHistogram);
+ isolate->SetAddHistogramSampleFunction(AddHistogramSample);
}
#endif // !V8_SHARED
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
