Reviewers: Hannes Payer,
Message:
Hannes, could you please take a look. The change in
CONSTANT_POOL_ARRAY_TYPE
causes tests to fail when enabling the out-of-line constant pool on Arm (see
https://codereview.chromium.org/228633002/ which I was trying to land).
Description:
Move CONSTANT_POOL_ARRAY_TYPE back into OldPointerSpace type.
r22270 moved CONSTANT_POOL_ARRAY_TYPE out of the OLD_POINTER_SPACE section
of
the type list
and into the OLD_DATA_SPACE section. This means that AllowedToBeMigrated
will
fail when
passed a ConstantPoolArray because the dst == TargetSpaceId(type) check
will be
false.
Please review this at https://codereview.chromium.org/379923007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/objects.h
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
007d4c10a0ff8db1521d53271490d5a62dbad7f9..a45baf3f881123c3fcff225f4ecfcd296b63a817
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -716,7 +716,6 @@ enum InstanceType {
FIXED_UINT8_CLAMPED_ARRAY_TYPE, // LAST_FIXED_TYPED_ARRAY_TYPE
FIXED_DOUBLE_ARRAY_TYPE,
- CONSTANT_POOL_ARRAY_TYPE,
FILLER_TYPE, // LAST_DATA_TYPE
// Structs.
@@ -743,6 +742,7 @@ enum InstanceType {
BREAK_POINT_INFO_TYPE,
FIXED_ARRAY_TYPE,
+ CONSTANT_POOL_ARRAY_TYPE,
SHARED_FUNCTION_INFO_TYPE,
// All the following types are subtypes of JSReceiver, which corresponds
to
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
