On 2014/07/10 07:53:53, Sven Panne wrote:
On 2014/07/10 07:01:55, Yang wrote:
> On 2014/07/09 11:46:24, aandrey wrote:
> > https://codereview.chromium.org/377213002/diff/1/src/api.cc
> > File src/api.cc (right):
> >
> >
https://codereview.chromium.org/377213002/diff/1/src/api.cc#newcode1249
> > src/api.cc:1249: EscapableHandleScope
> > scope(reinterpret_cast<Isolate*>(isolate));
> > On 2014/07/09 11:41:50, Yang wrote:
> > > Not sure whether we really need the handle scope to get rid of just
one
> extra
> > > handle.
> >
> > Removed.
>
> ping Sven.
In general we should refrain from silently injecting Handles into the
caller's
HandleScope, so the general rule of thumb is to use a
(Escapable)HandleScope
in
implementation of API functions. I'm not sure if we do it consistently,
though,
but we really should, otherwise things get interesting when you use API
entries
e.g. in a loop etc.
So the 1st patch set was actually nicer IMHO.
I see. My bad then.
https://codereview.chromium.org/377213002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
