Reviewers: Erik Corry,

Description:
"Port" (count >= 0) assertion in VirtualFrame::Drop to ia32 and x64.


Please review this at http://codereview.chromium.org/164251

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
   M     src/ia32/virtual-frame-ia32.cc
   M     src/x64/virtual-frame-x64.cc


Index: src/ia32/virtual-frame-ia32.cc
===================================================================
--- src/ia32/virtual-frame-ia32.cc      (revision 2654)
+++ src/ia32/virtual-frame-ia32.cc      (working copy)
@@ -965,6 +965,7 @@


  void VirtualFrame::Drop(int count) {
+  ASSERT(count >= 0);
    ASSERT(height() >= count);
    int num_virtual_elements = (element_count() - 1) - stack_pointer_;

Index: src/x64/virtual-frame-x64.cc
===================================================================
--- src/x64/virtual-frame-x64.cc        (revision 2654)
+++ src/x64/virtual-frame-x64.cc        (working copy)
@@ -206,6 +206,7 @@


  void VirtualFrame::Drop(int count) {
+  ASSERT(count >= 0);
    ASSERT(height() >= count);
    int num_virtual_elements = (element_count() - 1) - stack_pointer_;




--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to