LGTM.
http://codereview.chromium.org/165237/diff/1/3 File src/cfg.cc (right): http://codereview.chromium.org/165237/diff/1/3#newcode714 Line 714: PrintF("BinaryOp[%s] ", Token::Name(op())); If we print this on two lines, or don't print "BinaryOp", the instruction name field can get much shorter. I think that would be good. http://codereview.chromium.org/165237/diff/1/3#newcode734 Line 734: PrintF("L%d:\n", number()); number is a pretty non-descriptive name for the node number. http://codereview.chromium.org/165237 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
