Reviewers: rossberg,
Message:
Hi Andreas,
As requested, I'm uploading this patch now that I've implemented the
GetBindingValue part.
Does this look like a good approach?
I think it is doable to refactor the code to share the prototype walking
between
the two functions.
UnscopableLookupHelper res(isolate, name, object);
if (res.HasException()) { ... }
else if (res.FoundProperty()) { ... }
else { ... }
https://codereview.chromium.org/384963002/diff/1/src/contexts.cc
File src/contexts.cc (right):
https://codereview.chromium.org/384963002/diff/1/src/contexts.cc#newcode80
src/contexts.cc:80: while (true) {
I'll switch to use the new PrototypeIterator.
Description:
Unscopables WIP
DO NOT SUBMIT
BUG=v8:3401
LOG=N
Please review this at https://codereview.chromium.org/384963002/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+322, -1 lines):
M src/bootstrapper.cc
M src/contexts.h
M src/contexts.cc
M src/flag-definitions.h
M src/objects.h
M src/objects-inl.h
M src/runtime.cc
A test/mjsunit/harmony/unscopables.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
