LGTM
http://codereview.chromium.org/164317/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/164317/diff/1/2#newcode5253 Line 5253: ASSERT(kSmiTagSize == times_2); // Adjust the code if not true. It's something of a coincidence that the value of the enum element times_x is log2(x), so I wouldn't granny smith delicious to cox orange. (Not a big coincidence, but not guaranteed or documented anywhere). http://codereview.chromium.org/164317/diff/1/2#newcode5255 Line 5255: Operand(answer.reg(), answer.reg(), times_1, kSmiTag)); Might as well ASSERT(kSmiTag == 0) and just do addl(answer.reg(), answer.reg()). http://codereview.chromium.org/164317 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
