Reviewers: Michael Starzinger,
Message:
Hi Michael,
Here is the CL we discussed, PTAL,
--Michael
Description:
Enum RegisterInfo renamed to ParameterIndices.
"Info" is information-poor.
[email protected]
Please review this at https://codereview.chromium.org/385953004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -9 lines):
M src/code-stubs.h
M src/code-stubs.cc
M src/ic.h
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index
c36568c02c927d08a61bf7b767ce481f5169996e..d4745cc3f539cb6cce6799ed75833e42717e4d23
100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -576,7 +576,7 @@ void
KeyedLoadFastElementStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
Register registers[] = { LoadIC::ReceiverRegister(),
LoadIC::NameRegister() };
- STATIC_ASSERT(LoadIC::kRegisterArgumentCount == 2);
+ STATIC_ASSERT(LoadIC::kParameterCount == 2);
descriptor->Initialize(ARRAY_SIZE(registers), registers,
FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure));
}
@@ -586,7 +586,7 @@ void
KeyedLoadDictionaryElementStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
Register registers[] = { LoadIC::ReceiverRegister(),
LoadIC::NameRegister() };
- STATIC_ASSERT(LoadIC::kRegisterArgumentCount == 2);
+ STATIC_ASSERT(LoadIC::kParameterCount == 2);
descriptor->Initialize(ARRAY_SIZE(registers), registers,
FUNCTION_ADDR(KeyedLoadIC_MissFromStubFailure));
}
@@ -596,7 +596,7 @@ void
KeyedLoadGenericElementStub::InitializeInterfaceDescriptor(
CodeStubInterfaceDescriptor* descriptor) {
Register registers[] = { LoadIC::ReceiverRegister(),
LoadIC::NameRegister() };
- STATIC_ASSERT(LoadIC::kRegisterArgumentCount == 2);
+ STATIC_ASSERT(LoadIC::kParameterCount == 2);
descriptor->Initialize(
ARRAY_SIZE(registers), registers,
Runtime::FunctionForId(Runtime::kKeyedGetProperty)->entry);
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index
7f62b9ef44c34073216d8fdd513428bcfeaf9af7..5dc9896cf7347be794062c58d2d902ac98d4f62a
100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -2456,12 +2456,12 @@ class ElementsTransitionAndStoreStub : public
HydrogenCodeStub {
CodeStubInterfaceDescriptor* descriptor) V8_OVERRIDE;
// Parameters accessed via CodeStubGraphBuilder::GetParameter()
- enum RegisterInfo {
+ enum ParameterIndices {
kValueIndex,
kMapIndex,
kKeyIndex,
kObjectIndex,
- kRegisterArgumentCount
+ kParameterCount
};
static const Register ValueRegister() {
Index: src/ic.h
diff --git a/src/ic.h b/src/ic.h
index
262893f3965dadb443509791578306b3fd04021e..4647c9c6d1853acabd46b073cc8f7636f6e74b2b
100644
--- a/src/ic.h
+++ b/src/ic.h
@@ -396,10 +396,10 @@ class LoadIC: public IC {
class ContextualModeBits: public BitField<ContextualMode, 0, 1> {};
STATIC_ASSERT(static_cast<int>(NOT_CONTEXTUAL) == 0);
- enum RegisterInfo {
+ enum ParameterIndices {
kReceiverIndex,
kNameIndex,
- kRegisterArgumentCount
+ kParameterCount
};
static const Register ReceiverRegister();
static const Register NameRegister();
@@ -583,11 +583,11 @@ class StoreIC: public IC {
static const ExtraICState kStrictModeState =
1 << StrictModeState::kShift;
- enum RegisterInfo {
+ enum ParameterIndices {
kReceiverIndex,
kNameIndex,
kValueIndex,
- kRegisterArgumentCount
+ kParameterCount
};
static const Register ReceiverRegister();
static const Register NameRegister();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
