Revision: 22392
Author: [email protected]
Date: Tue Jul 15 08:10:26 2014 UTC
Log: Fix flags for test cases involving arrow functions
There are a lot of tests in cctest/test-parsing/ErrorsArrowFunctions,
so it is quite slow. This patch removes some flags to make it faster.
Removing three flags that don't affect the test brings down the run
time one order of magnitude, which is fast enough even for debug/ASAN
bots.
Also, remove the unneeded kArrowFunctions flag from
cctest/test-parsing/NoErrorsYieldSloppyAllModes
BUG=
[email protected]
Review URL: https://codereview.chromium.org/387383002
Patch from Adrián Pérez de Castro <[email protected]>.
http://code.google.com/p/v8/source/detail?r=22392
Modified:
/branches/bleeding_edge/test/cctest/test-parsing.cc
=======================================
--- /branches/bleeding_edge/test/cctest/test-parsing.cc Mon Jul 14 07:55:45
2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-parsing.cc Tue Jul 15 08:10:26
2014 UTC
@@ -1815,9 +1815,7 @@
NULL
};
- static const ParserFlag always_flags[] = {kAllowArrowFunctions};
- RunParserSyncTest(context_data, statement_data, kSuccess, NULL, 0,
- always_flags, ARRAY_SIZE(always_flags));
+ RunParserSyncTest(context_data, statement_data, kSuccess);
}
@@ -3088,7 +3086,13 @@
NULL
};
- RunParserSyncTest(context_data, statement_data, kError);
+ // The test is quite slow, so run it with a reduced set of flags.
+ static const ParserFlag flags[] = {
+ kAllowLazy, kAllowHarmonyScoping, kAllowGenerators
+ };
+ static const ParserFlag always_flags[] = { kAllowArrowFunctions };
+ RunParserSyncTest(context_data, statement_data, kError, flags,
+ ARRAY_SIZE(flags), always_flags,
ARRAY_SIZE(always_flags));
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
