On 2014/07/15 08:09:13, Yang wrote:
On 2014/07/15 07:47:59, Michael Starzinger wrote:
> By now this seems to be a matter of removing asserts. Please note that
this
> change still doesn't do short-circuiting of embedded ConsString objects
in
code.
> This can be done in a follow-up CL if necessary by adapting
> VisitEmbeddedPointer.
LGTM. You may want to look at HStringAdd::New and the call to
Factory::NewFlatConcatString. The reason we use that instead of
Factory::NewConsString is this as well, iirc.
Done.
https://codereview.chromium.org/395713002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
