https://codereview.chromium.org/398513005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/398513005/diff/1/src/runtime.cc#newcode1742
src/runtime.cc:1742: Handle<Object> key(table->KeyAt(i), isolate);
On 2014/07/16 12:10:58, Yang wrote:
Indentation size is weird. We use 4 spaces for line break and 2 spaces
for
scopes. You could also use "git cl format" to have it formatted for
you.
Done.
https://codereview.chromium.org/398513005/diff/1/test/mjsunit/harmony/mirror-collections.js
File test/mjsunit/harmony/mirror-collections.js (right):
https://codereview.chromium.org/398513005/diff/1/test/mjsunit/harmony/mirror-collections.js#newcode9
test/mjsunit/harmony/mirror-collections.js:9: var serializer =
debug.MakeMirrorSerializer();
On 2014/07/16 12:10:58, Yang wrote:
Same here. 2 space indentation please.
Done.
https://codereview.chromium.org/398513005/diff/1/test/mjsunit/harmony/mirror-collections.js#newcode51
test/mjsunit/harmony/mirror-collections.js:51: assertEquals(44,
entries[5]);
On 2014/07/16 12:10:58, Yang wrote:
Having MapMirror.entries() contain both keys and value is somewhat
confusing. It
would be nicer to have an array of key/value pairs. That way,
entries.length
will also not be twice the actual number of added mappings.
On the other hand that would add some more overhead when preparing
that array.
We could have methods on MapMirror that would abstract away from
direct access
to entries, but then it becomes unclear when to refresh the entries
array.
:/
I've changed the return value of MapMirror.entries() to the array of
key/value pairs (objects).
I don't quite get the second part of your comment, however. We'd just
like to be able to pull all entries from a map at the given moment. So,
it's kind of a snapshot of the map. Could there be any issues with it?
https://codereview.chromium.org/398513005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
