Revision: 22463
Author:   [email protected]
Date:     Fri Jul 18 08:25:41 2014 UTC
Log:      Add histograms for idle notification and incremental marking steps

BUG=381820
LOG=n
[email protected]

Review URL: https://codereview.chromium.org/401793002
http://code.google.com/p/v8/source/detail?r=22463

Modified:
 /branches/bleeding_edge/src/counters.h
 /branches/bleeding_edge/src/heap.cc

=======================================
--- /branches/bleeding_edge/src/counters.h      Mon Jul  7 07:19:46 2014 UTC
+++ /branches/bleeding_edge/src/counters.h      Fri Jul 18 08:25:41 2014 UTC
@@ -292,18 +292,20 @@
 };


-#define HISTOGRAM_TIMER_LIST(HT)                                      \
-  /* Garbage collection timers. */                                    \
-  HT(gc_compactor, V8.GCCompactor)                                    \
-  HT(gc_scavenger, V8.GCScavenger)                                    \
-  HT(gc_context, V8.GCContext) /* GC context cleanup time */          \
-  /* Parsing timers. */                                               \
-  HT(parse, V8.Parse)                                                 \
-  HT(parse_lazy, V8.ParseLazy)                                        \
-  HT(pre_parse, V8.PreParse)                                          \
-  /* Total compilation times. */                                      \
-  HT(compile, V8.Compile)                                             \
-  HT(compile_eval, V8.CompileEval)                                    \
+#define HISTOGRAM_TIMER_LIST(HT)                             \
+  /* Garbage collection timers. */                           \
+  HT(gc_compactor, V8.GCCompactor)                           \
+  HT(gc_scavenger, V8.GCScavenger)                           \
+  HT(gc_context, V8.GCContext) /* GC context cleanup time */ \
+  HT(gc_idle_notification, V8.GCIdleNotification)            \
+  HT(gc_incremental_marking, V8.GCIncrementalMarking)        \
+  /* Parsing timers. */                                      \
+  HT(parse, V8.Parse)                                        \
+  HT(parse_lazy, V8.ParseLazy)                               \
+  HT(pre_parse, V8.PreParse)                                 \
+  /* Total compilation times. */                             \
+  HT(compile, V8.Compile)                                    \
+  HT(compile_eval, V8.CompileEval)                           \
   HT(compile_lazy, V8.CompileLazy)

 #define HISTOGRAM_PERCENTAGE_LIST(HP)                                 \
=======================================
--- /branches/bleeding_edge/src/heap.cc Thu Jul 17 13:00:46 2014 UTC
+++ /branches/bleeding_edge/src/heap.cc Fri Jul 18 08:25:41 2014 UTC
@@ -4227,6 +4227,9 @@


 void Heap::AdvanceIdleIncrementalMarking(intptr_t step_size) {
+  HistogramTimerScope idle_notification_scope(
+      isolate_->counters()->gc_incremental_marking());
+
   incremental_marking()->Step(step_size,
                               IncrementalMarking::NO_GC_VIA_STACK_GUARD);

@@ -4263,6 +4266,9 @@
   intptr_t step_size =
       size_factor * IncrementalMarking::kAllocatedThreshold;

+  HistogramTimerScope idle_notification_scope(
+      isolate_->counters()->gc_idle_notification());
+
   if (contexts_disposed_ > 0) {
     contexts_disposed_ = 0;
     int mark_sweep_time = Min(TimeMarkSweepWouldTakeInMs(), 1000);

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to