lgtm once comments are addressed:
https://codereview.chromium.org/392243002/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/392243002/diff/40001/src/objects.cc#newcode3044
src/objects.cc:3044: if (it->HolderIsReceiver() ||
&&
https://codereview.chromium.org/392243002/diff/40001/src/objects.cc#newcode3050
src/objects.cc:3050: // Fall through.
Wrong identation.
https://codereview.chromium.org/392243002/diff/40001/src/objects.cc#newcode3089
src/objects.cc:3089: bool is_observed = receiver->map()->is_observed();
Should we observe modifications of "hidden_string" field?
https://codereview.chromium.org/392243002/diff/40001/src/objects.cc#newcode3152
src/objects.cc:3152: if (receiver->map()->is_observed()) {
Same here.
https://codereview.chromium.org/392243002/diff/40001/src/v8natives.js
File src/v8natives.js (right):
https://codereview.chromium.org/392243002/diff/40001/src/v8natives.js#newcode1326
src/v8natives.js:1326: %DebugPrint(name);
Spurious change?
https://codereview.chromium.org/392243002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
