On 2014/07/19 20:33:27, aperez wrote:
On 2014/07/16 11:59:42, rossberg wrote:
> On 2014/07/16 11:42:14, aperez wrote:
> > On 2014/07/16 11:18:52, aperez wrote:
> >
> > > Ah, let me do a build with GCC and werror=yes -- with my version of
Clang
> here
> > > I need to pass werror=no and sometimes I miss things :-/
> >
> > With this I have also catched a signed vs. unsigned comparison in
> > "test-parsing.cc". The last version of the patchset builds now fine
> > with "werror=yes" and it should be good to land.
>
> Hm, does the test suite run through for you? I see plenty of tests
failing
right
> now.
Fixed, it ws two things: I missed adding FunctionisArrow to the list of
runtime
functions in "runtime.h". Also, I have changed a couple of cases in which
the
code
was like:
return Blah(CHECK_OK);
to:
result = Blah(CHECK_OK);
return result;
This makes sure that the CHECK_OK macro is expanded in a way that makes
sense.
https://codereview.chromium.org/382893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
