LGTM On Thu, Aug 13, 2009 at 11:37, <[email protected]> wrote:
> Reviewers: Lasse Reichstein, > > Description: > Changed semi space Grow to be rounded to OS page size. > > > Please review this at http://codereview.chromium.org/164469 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/spaces.cc > > > Index: src/spaces.cc > =================================================================== > --- src/spaces.cc (revision 2673) > +++ src/spaces.cc (working copy) > @@ -1076,7 +1076,7 @@ > > bool SemiSpace::Grow() { > // Commit 50% extra space but only up to maximum capacity. > - int extra = capacity_/2; > + int extra = RoundUp(capacity_/2, OS::AllocateAlignment()); > if (capacity_ + extra > maximum_capacity_) { > extra = maximum_capacity_ - capacity_; > } > > > -- Lasse R.H. Nielsen / [email protected]'Faith without judgement merely degrades the spirit divine' --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
