Hi Danno,
I addressed your comments and fixed a TODO. Have a look when you get a
chance,
thanks!
--Michael
https://codereview.chromium.org/368263003/diff/80001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/368263003/diff/80001/src/code-stubs.h#newcode756
src/code-stubs.h:756: class IsJsArrayBits: public BitField<bool, 16, 1>
{};
On 2014/07/11 12:30:30, danno wrote:
Any particular reason you start this field at bit 16 and not 8? You
may want to
make the bit selection semi-automatic like FieldIndex does.
Oops, thanks that is a bug because I removed a NewElementsKindBits field
that was there before. Done.
https://codereview.chromium.org/368263003/diff/80001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/368263003/diff/80001/src/hydrogen-instructions.h#newcode2331
src/hydrogen-instructions.h:2331: if (index < 2) {
On 2014/07/11 12:30:30, danno wrote:
I think a little more comments/constants are needed here... what are
the first
two parameters, and why are they always tagged... context and
JSFunction?
Happily, we've now repaired this whole area so this CL no longer touches
HCallWithDescriptor.
https://codereview.chromium.org/368263003/diff/80001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/368263003/diff/80001/src/ia32/lithium-ia32.cc#newcode1145
src/ia32/lithium-ia32.cc:1145: ops, zone());
On 2014/07/11 12:30:30, danno wrote:
clang format the patch?
This whole block is gone, I no longer need to change
DoCallWithDescriptor().
https://codereview.chromium.org/368263003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
