LGTM

http://codereview.chromium.org/164472/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/164472/diff/1/2#newcode1611
Line 1611: EnsureSpace ensure_space(this);
Move ensure_space below the call to testb, which has its own
ensure_space.

http://codereview.chromium.org/164472/diff/1/2#newcode1613
Line 1613: if ((mask.value_ & 0xFFFFFF00) == 0) {
Use is_uint8 to test.

http://codereview.chromium.org/164472/diff/1/2#newcode1631
Line 1631: EnsureSpace ensure_space(this);
Same comments as above.

http://codereview.chromium.org/164472

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to