On 2014/07/22 08:53:29, Jakob wrote:
LGTM, thanks!
One comment for the record: this approach might get confused by "arm" vs.
"arm64". I don't think that's a problem right now; but *if* we find
ourselves
in
need of yet more logic, I think the next attempt should be an explicit
table
of
replacements (cf. build/detect_v8_host_arch.py; might even extend that
file
and
have Make call out to Python).
lgtm too (btw, I'm rmcilroy, not mcilroy - not sure who that is :))
https://codereview.chromium.org/408133002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
