lgtm with nits
https://codereview.chromium.org/405373005/diff/60001/build/get_landmines.py
File build/get_landmines.py (right):
https://codereview.chromium.org/405373005/diff/60001/build/get_landmines.py#newcode3
build/get_landmines.py:3: # Copyright 2013 The Chromium Authors. All
rights reserved.
for other files we imported, we just stripped this part
https://codereview.chromium.org/405373005/diff/60001/build/get_landmines.py#newcode20
build/get_landmines.py:20: # if builder() == 'make':
if you want to use builder, you also need to import the utils
https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py
File build/landmine_utils.py (right):
https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py#newcode105
build/landmine_utils.py:105: return 'ninja'
we use make, no?
https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py#newcode109
build/landmine_utils.py:109: return 'ninja'
and msvs
https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py#newcode111
build/landmine_utils.py:111: return 'ninja'
and make here
https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py#newcode113
build/landmine_utils.py:113: return 'ninja'
and xcode there
https://codereview.chromium.org/405373005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
