https://codereview.chromium.org/402423003/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/402423003/diff/1/src/mirror-debugger.js#newcode1338
src/mirror-debugger.js:1338: var iter = %_CallFunction(this.value_,
builtins.SetEntries);
On 2014/07/22 15:15:10, arv wrote:
You can do SetValues here instead. No need for the extra array
allocation here.
Thanks, fixed it.
https://codereview.chromium.org/402423003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/402423003/diff/1/src/runtime.cc#newcode1801
src/runtime.cc:1801: RUNTIME_FUNCTION(Runtime_GetWeakSetEntries) {
On 2014/07/22 15:15:10, arv wrote:
-> GetWeakSetValues
Done, also renamed SetMirror.prototype.entries ->
SetMirror.prototype.values.
https://codereview.chromium.org/402423003/diff/1/src/runtime.cc#newcode1806
src/runtime.cc:1806: Handle<FixedArray> entries =
On 2014/07/22 15:15:10, arv wrote:
entries is misleading since you are not return an array of pairs here.
Fixed.
https://codereview.chromium.org/402423003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
