LGTM, just nits.
https://codereview.chromium.org/391413006/diff/80001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/391413006/diff/80001/src/heap.cc#newcode6082
src/heap.cc:6082: Max(current_.start_time - previous_.end_time, 0.0);
Can this line be negative? That's strange, it should always be a
positive value.
https://codereview.chromium.org/391413006/diff/80001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode550
src/heap.h:550: // TODO(ernstm): Move into GCTracer
"."
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode634
src/heap.h:634: // TODO(ernstm): unit tests. move to separate file.
Unit tests. Move to separate file.
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode748
src/heap.h:748: typedef RingBuffer<Event, 10> EventBuffer;
Can we make 10 a proper constant.
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode765
src/heap.h:765: // TODO(ernstm): move to Heap.
"Move"
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode769
src/heap.h:769: // TODO(ernstm): move to Heap.
"Move"
https://codereview.chromium.org/391413006/diff/80001/src/heap.h#newcode783
src/heap.h:783: Event previous_mark_compactor_;
previous_mark_compactor_event_
https://codereview.chromium.org/391413006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
