https://codereview.chromium.org/409743004/diff/1/src/types.h
File src/types.h (right):
https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode71
src/types.h:71: // UntaggedInt = UntaggedInt8 \/ UntaggedInt16 \/
UntaggedInt32)
Should include Int1 now. Also, spurious paren.
https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode614
src/types.h:614: i::Handle<i::Map> map, TypeHandle bound, Region*
region) {
While you're at it, can you also add assertions for bound? Here, for
Constant, and for Context? (using InherentLub)
https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode682
src/types.h:682: ASSERT(SEMANTIC(bound->AsBitset() |
BitsetType::kNumber)
Make this a proper subtype check for both axes, and use InherentLub.
https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode746
src/types.h:746: ASSERT(SEMANTIC(bound->AsBitset()) ==
SEMANTIC(BitsetType::kArray));
Same here.
https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode783
src/types.h:783: ASSERT(SEMANTIC(bound->AsBitset()) ==
SEMANTIC(BitsetType::kFunction));
And here.
https://codereview.chromium.org/409743004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
